[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Changes in update-game-score.c

From: David Kastrup
Subject: Re: Changes in update-game-score.c
Date: Wed, 22 Jan 2014 20:50:19 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux)

Eli Zaretskii <address@hidden> writes:

> Can we please stop futzing with this silly program, while in feature
> freeze?  Why do we suddenly care about it so much?  Those changes do
> nothing useful, and risk breaking builds, e.g.:
>   ./update-game-score.c: In function `write_scores':
>   ./update-game-score.c:446: warning: implicit declaration of function 
> `fchmod'
>   gcc -std=gnu99 -mtune=pentium4 -I. -I../src -I../lib -I. -I./../src
> -I./../lib -mtune=pentium4 -DUSE_CRT_DLL=1 -I
> /d/gnu/bzr/emacs/trunk/nt/inc -O0 -gdwarf-2 -g3 -o test-distrib.exe
> ./test-distrib.c
>   d:/usr/tmp/cckhdaaa.o(.text+0xe24): In function `write_scores':
>   d:\gnu\bzr\emacs\trunk\lib-src/./update-game-score.c:446: undefined
> reference to `fchmod'
>   collect2: ld returned 1 exit status

You fixed the breakage for Windows NT, but fchmod is not generally
available on a _lot_ of platforms.  Without a proper autoconf test, the
whole change should be reverted.

David Kastrup

reply via email to

[Prev in Thread] Current Thread [Next in Thread]