[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Changes in update-game-score.c

From: Eli Zaretskii
Subject: Re: Changes in update-game-score.c
Date: Thu, 23 Jan 2014 18:02:09 +0200

> Date: Thu, 23 Jan 2014 05:53:47 +0200
> From: Eli Zaretskii <address@hidden>
> Cc: address@hidden
> > Date: Wed, 22 Jan 2014 19:33:58 -0800
> > From: Paul Eggert <address@hidden>
> > 
> > This problem isn't limited to update-game-score. I found three other 
> > instances in Emacs. The first was in qcopy_acl (called by Fcopy_file) 
> > and I fixed it in trunk bzr 116124. The other two are in fileio.c and 
> > filelock.c. The attached patch should fix it; I plan to install it 
> > unless someone points out a problem with it.
> Please don't install this, we've been living with this "problem" long
> enough to leave it for afterwards.

And on top of that, it would break the Windows build, because gnulib
functions called by Emacs can no longer call libc functions that
accept file names, since we now pass UTF-8 encoded file names to them.
So where formerly fchmod was a no-op that always succeeded, fnchmod
will now be a no-op that always fails, and filelock.c will stop

reply via email to

[Prev in Thread] Current Thread [Next in Thread]