[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Override Windows default Win-* key combinations when using E

From: Eli Zaretskii
Subject: Re: [PATCH] Override Windows default Win-* key combinations when using Emacs
Date: Tue, 12 Jan 2016 17:54:47 +0200

> From: Jussi Lahdenniemi <address@hidden>
> Cc: address@hidden
> Date: Tue, 12 Jan 2016 13:16:14 +0200
> > I've briefly reviewed the rest of the patch, and it looks OK to me.
> > Did you make sure the new code doesn't call any API that might be
> > unavailable on older systems?  We still support Windows 98 and later.
> Unfortunately, Windows 98 does not include the low-level keyboard hook 
> functionality that is essential for my code to work. It is supported in 
> Windows 2000 (and even NT4, apparently), but not on the 95/98/ME branch.
> So, probably I would need to change the code so that the old 
> functionality is preserved and used if the new API are not available 
> (pre-Win2000), in the same style that w32uniscribe works?

Which APIs that you used in the patch are not available on Windows 9X?
I thought I went over all of them, and they all are, but maybe I
missed some.

Most of the examples of how to use an API that might not be available
and should be detected at run time are in w32.c, although
w32uniscribe.c also does something similar in a few cases.

> > Also, I understand that this code will work on versions of Windows
> > before v8, is that right?
> I have tested the code on Windows 10 (my physical PC) and Windows 7 (in 
> a VM) both as 32-bit and 64-bit versions. I'll try to get Win2000 
> installed on another VM as well and test with it, just to be sure.

If W2K is difficult to get by, XP should be good enough.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]