[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: A cleaning-up patch for parse-time.el

From: John Wiegley
Subject: Re: A cleaning-up patch for parse-time.el
Date: Sat, 19 Mar 2016 00:41:28 -0700
User-agent: Gnus/5.130014 (Ma Gnus v0.14) Emacs/25.0.92 (darwin)

>>>>> Marcin Borkowski <address@hidden> writes:

> in my attempt to enhance Org-mode's date/time parsing, I found out that
> I'll probably need to submit some modifications to `parse-time-string'.
> While studying parse-time.el, I encountered some code whose purpose was
> not obvious at the first glance, so I corrected it.  I attach a patch.
> Is submitting such a patch a good idea?  (It does not introduce any new
> features or bugfixes, just cleaning up: adding/expanding docstrings,
> making one argument name better, adding a newline, and changing `not'
> into `null'.)  How do I write a commit message for that?  (I went for
> simplicity/terseness, since the diff speaks for itself.)

Hi Marcin,

If you also include tests that show that the behavior is unchanged or merely
corrected from what we had before, then this sounds like something that would
be good for emacs-25. Otherwise, I'd suggest it be a patch against master,
pending review by others.

John Wiegley                  GPG fingerprint = 4710 CF98 AF9B 327B B80F
http://newartisans.com                          60E1 46C4 BD1A 7AC1 4BA2

reply via email to

[Prev in Thread] Current Thread [Next in Thread]