Re: Patches for Emacs 25.2

[Dmitry Gutov]

Hi Michael,

On 18.10.2016 15:32, Michael Albinus wrote:

> I don't decide whether such a patch shall be applied; it shall be
> decided by the vc maintainer. But in case of, the patch could be written
> shorter:

Thanks. I don't like it (for obvious reason you mentioned yourself), but 
since it's emacs-25-only, it should be fine, with the following minor 
concerns:

> !           (if (eq system-type 'windows-nt)
> !               (if (file-remote-p file1)
> !                 (with-parsed-tramp-file-name file1 nil
> !                     (tramp-make-tramp-file-name
> !                    method user host
> !                    (tramp-make-tramp-temp-file v)))
> !                   (make-temp-file "git-msg")))))

Please do not introduce tabs here.

> !              (nconc (if msg-file
> !                         (list
> !                        "commit" "-F"
> !                        (or (file-remote-p msg-file 'localname)  msg-file))

Can't we move the (file-remote-p ... 'localname) call to the first hunk 
here? Then the patch will only change one place, and we get rid of the 
added `or' here.