[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Patches for Emacs 25.2

From: Michael Albinus
Subject: Re: Patches for Emacs 25.2
Date: Mon, 07 Nov 2016 10:01:07 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.0.50 (gnu/linux)

Dmitry Gutov <address@hidden> writes:

> Hi Michael,

Hi Dmitry,

>> !              (nconc (if msg-file
>> !                         (list
>> !                     "commit" "-F"
>> !                     (or (file-remote-p msg-file 'localname)  msg-file))
> Can't we move the (file-remote-p ... 'localname) call to the first
> hunk here? Then the patch will only change one place, and we get rid
> of the added `or' here.

I let it to Nikolay. However, given that this construct

  (or (file-remote-p FILE 'localname) FILE)

happens several times in the lisp sources, I wonder whether we shall
give it an own defmacro or defsubst (in master, of course).

reply via email to

[Prev in Thread] Current Thread [Next in Thread]