[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Emacs-diffs] master fd8f724: * src/xdisp.c (overlay_arrows_changed_
Re: [Emacs-diffs] master fd8f724: * src/xdisp.c (overlay_arrows_changed_p): Fix last change.
Fri, 03 Mar 2017 10:11:03 +0200
> From: Stefan Monnier <address@hidden>
> Date: Thu, 02 Mar 2017 17:32:52 -0500
> >> > Isn't it easier to keep the record of changes in these variables in
> >> > the buffer object, like we do with BUF_MODIFF etc.?
> >> I don't understand the question. Which "these variables" are you
> >> talking about?
> > The 3 variables related to overlay-arrow whose changes need to trigger
> > redisplay of the respective buffers: overlay-arrow-position,
> > overlay-arrow-string, and overlay-arrow-bitmap.
> But that means we need to watch variable assignments, marker
> modifications, and symbol property modifications. Using overlays gets
> us all this "for free" because we already watch all overlay modifications.
Variables and markers, yes. Symbol properties: I don't see why would
we need to watch them.
Anyway, it was just a thought. It sounds like a conceptually simpler,
even if the implementation is somewhat hairy.