|
From: | Dmitry Gutov |
Subject: | Re: [SUSPECTED SPAM] Re: [Emacs-diffs] scratch/widen-less a4ba846: Replace prog-widen with consolidating widen calls |
Date: | Thu, 14 Dec 2017 11:32:38 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:58.0) Gecko/20100101 Thunderbird/58.0 |
On 12/11/17 11:43 PM, John Wiegley wrote:
GD> Not sure I understand your question. Do you want a full description of the DG> changes? I can rebase the branch first before merging, and add proper DG> change log messages. Please. :)
I've pushed it to widen-less (without scratch/ now). Comments welcome!It keeps prog-indentation-context for its first element (for change-minimization and possibly emotional reasons; but who knows, someday we might add some, specific only to indentation). The added bonus is that calling prog-first-column is easier than digging out the first element of the list.
What is not included, but probably should be:- Manual changes describing that font-lock matchers shouldn't call 'widen' either. It's an important thing, but so far it's been only an issue with CC Mode, which isn't supported anyway (so far). So: should that info be included, and where should I put it?
- Similar info for syntax-propertize-function, though no violators have been observed so far.
These will be documentation-only changes. What is not included, and maybe should wait until Emacs 27:- Similar consolidations of 'widen' calls for add-log-current-defun, eldoc-print-current-symbol-info, beginning-of-defun-function and others. And accompanying documentation (again, where should it go?).
[Prev in Thread] | Current Thread | [Next in Thread] |