[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: package.el strings

From: Jean-Christophe Helary
Subject: Re: package.el strings
Date: Wed, 18 Apr 2018 15:38:26 +0900

Almost 9 months and nothing in master. Was there anything wrong with the code?


On Jul 22, 2017, at 18:23, Eli Zaretskii <address@hidden> wrote:

From: Jean-Christophe Helary <address@hidden>
Date: Tue, 18 Jul 2017 00:28:59 +0900

-   (concat
-    (when delete "Delete ")
-    (package-menu--list-to-prompt delete)
-    (when (and delete install)
-      (if upgrade "; " "; and "))
-    (when install "Install ")
-    (package-menu--list-to-prompt install)
-    (when (and upgrade (or install delete)) "; and ")
-    (when upgrade "Upgrade ")
-    (package-menu--list-to-prompt upgrade)
-    "? ")))
+   (format "Number of packages to delete: %s / install: %s / upgrade: %s, proceed? "
+   (package-menu--list-to-prompt delete)
+   (package-menu--list-to-prompt install)
+   (package-menu--list-to-prompt upgrade))))

This loses the feature of saying just what's needed, instead of
showing zero.  Can we do better?

If you ask, there probably is a way... I'll try to find something better.

Ok, I found something for this part that I also adapted to 2 other parts that I had overly simplified. I also made a few modifications here and there compared to my original file.

Thanks, this looks OK.  Could someone who uses/makes changes in
package.el please review these and, if OK, push to master?

Jean-Christophe Helary
http://mac4translators.blogspot.com @brandelune

reply via email to

[Prev in Thread] Current Thread [Next in Thread]