[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: bignum branch

From: Tom Tromey
Subject: Re: bignum branch
Date: Wed, 08 Aug 2018 17:37:27 -0600
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.50 (gnu/linux)

>>>>> "Andy" == Andy Moreton <address@hidden> writes:

Andy> Have you run "make check" on the bignum branch ?

I did this and fixed the problems I saw.

Andy> 1) A crash in the json tests
Andy>    This is bug#32381, fixed on master in commit 3eac378c96.

I didn't see this, but since it is unrelated to the branch, I wouldn't
have anyway.

I just ran "make check" at the top level.  Is there something else I
should do?

Andy> 2) An eassert in make_bignum_str called from string_to_number.
Andy>    This appears to be caused by differences in the syntax accepted by
Andy>    emacs lisp and by mpz_set_str.  To reproduce:
ELISP> (format "+%S" (- most-negative-fixnum))
Andy>      "+2305843009213693952"
ELISP> (string-to-number "+2305843009213693952")
Andy>      ### crash ###

I fixed this.

Andy> 3) Another crash which I have not yet had time to analyse with gdb.

I didn't see this.  However, emacs-module-tests.el had a test failure;
I've updated the test.

I've pushed all the patches I have.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]