[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: harfbuzz 2f72162: Fix crash in the Cairo build

From: Eli Zaretskii
Subject: Re: harfbuzz 2f72162: Fix crash in the Cairo build
Date: Fri, 08 Feb 2019 15:14:30 +0200

> From: Robert Pluim <address@hidden>
> Cc: address@hidden
> Date: Fri, 08 Feb 2019 12:46:32 +0100
> >> ./configure                # This builds xfont.o ftfont.o xftfont.o 
> >> ftxfont.o
> >
> > I wonder why we build both xftfont.o and ftxfont.o, when we only use
> > one of them, if my reading of the code is correct.
> >
> I did suggest removing ftxfont.o, but you said we had to deprecate it
> first. Itʼs easy enough to not build in the HAVE_XFT config.

That's orthogonal.  Regardless of whether we want to drop ftxfont.c, I
don't understand why build with both xftfont.c and ftxfont.c.  They
seem to be mutually exclusive, from the end-user POV.

> >> I can cherry-pick this to the harfbuzz branch if you want.
> >
> > Thanks, please do.
> Will do.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]