[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's ove
From: |
Eli Zaretskii |
Subject: |
Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line |
Date: |
Sun, 17 Mar 2019 22:40:02 +0200 |
> Date: Sun, 17 Mar 2019 23:27:30 +0300
> From: Konstantin Kharlamov <address@hidden>
> Cc: address@hidden
>
> >> Okay, so: ^M appears in selective-display-mode only in the end of a
> >> line.
> >
> > No, ^M _replaces_ newline characters, so what was previously several
> > lines is now a single long line.
>
> Sure, but after the patch we don't match the whole line anymore. We
> only match the tag. We don't care if it's at the beginning of the line
> or in the middle of it. We only look for the tag. So we don't care if
> line has a newline character or ^M.
But that's incorrect: a tag in a tags table always begins at the
beginning of a line, so it must be a search anchored at the beginning
of the line. And in selective-display mode ^M counts as the beginning
of a line.
- Eradicating selective-display == t (was: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line), (continued)
- Eradicating selective-display == t (was: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line), Stefan Monnier, 2019/03/17
- Re: Eradicating selective-display == t (was: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line), Konstantin Kharlamov, 2019/03/17
- Re: Eradicating selective-display == t, Stefan Monnier, 2019/03/17
- Re: Eradicating selective-display == t, Konstantin Kharlamov, 2019/03/18
- Re: Eradicating selective-display == t, Stefan Monnier, 2019/03/18
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Konstantin Kharlamov, 2019/03/17
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Eli Zaretskii, 2019/03/17
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Konstantin Kharlamov, 2019/03/17
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Eli Zaretskii, 2019/03/17
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Konstantin Kharlamov, 2019/03/17
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line,
Eli Zaretskii <=
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Konstantin Kharlamov, 2019/03/17
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Eli Zaretskii, 2019/03/17
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Konstantin Kharlamov, 2019/03/18
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Konstantin Kharlamov, 2019/03/18
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Eli Zaretskii, 2019/03/18
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Konstantin Kharlamov, 2019/03/18
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Konstantin Kharlamov, 2019/03/18
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Eli Zaretskii, 2019/03/18
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Konstantin Kharlamov, 2019/03/18
- Re: [PATCH 2/3] lisp/progmodes/etags.el don't (forward-char) as it's overriden next line, Konstantin Kharlamov, 2019/03/18