[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: CHECK_STRUCTS/dmpstruct.h mechanism is broken.

From: Andy Moreton
Subject: Re: CHECK_STRUCTS/dmpstruct.h mechanism is broken.
Date: Mon, 15 Apr 2019 13:36:39 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.2 (windows-nt)

On Wed 10 Apr 2019, Paul Eggert wrote:

> Daniel Colascione wrote:
>> What would make the hashes easier to deal with? Some make target for
>> updating them automatically? An easier way to disable the check at
>> configure time? Transformation into a prominent runtime warning instead of
>> a build break?
> It's better to have the build break than to have a runtime check. Of the two
> other approaches you mentioned, I think a configure-time option is the better
> idea. Since these hashes are aimed at developers and are are not needed for
> ordinary builds from tarballs, I think the hashes should be checked on
> request. I resurrected the hashes by installing the attached patch and they
> are now checked with the longstanding 'configure' option --enable-checking=all
> or with the new 'configure' option --enable-checking=structs. Comments welcome
> as usual.

This newly resurrected checking is already broken on master, which does
not build with confgiure option "--enable-checking=yes,glyphs".

The struct fingerprint checking should default to enabled (as before)
with the configure arguments allowing it to be (temporarily) disabled.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]