[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: CHECK_STRUCTS/dmpstruct.h mechanism is broken.

From: Andy Moreton
Subject: Re: CHECK_STRUCTS/dmpstruct.h mechanism is broken.
Date: Wed, 10 Apr 2019 14:12:20 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1.92 (windows-nt)

On Tue 09 Apr 2019, Paul Eggert wrote:

> On 3/4/19 6:17 PM, Paul Eggert wrote:
>> On 2/28/19 12:59 PM, Alan Mackenzie wrote:
>>> is all this really needed?  Is pdumper.c really that fragile,
>>> that it can't cope with changes in certain structs?
>> No, it's not needed, and in my experience the mechanism's costs far
>> exceed any benefit.
> No further comment and the mechanism just bit me again, so I installed
> the attached patch to disable it. We can reenable it later if needed
> (which I hope won't happen....).

This patch seems to be ok, but your following patch in commit d826037475
("Remove the need for temacs.in") breaks out of tree builds.

It seems to me that the patch contains a mixture of changes to remove
temacs.in support, and a number of unrelated changes to Makefile.in
files which break the build.

For example, this breaks out-of-tree builds, as make tries to use
/path/to/emacs/admin/charsets/Makefile rather than the correct path

    diff --git a/src/Makefile.in b/src/Makefile.in
    index 0613a0dbed..f8a2ffadc2 100644
    --- a/src/Makefile.in
    +++ b/src/Makefile.in
    @@ -533,7 +533,7 @@ ${lispintdir}/cp51932.el ${lispintdir}/eucjp-ms.el:

     charsets = ${top_srcdir}/admin/charsets/charsets.stamp
     ${charsets}: FORCE
    -   ${MAKE} -C ../admin/charsets all
    +   $(MAKE) -C $(dir $@) all

     charscript = ${lispintdir}/charscript.el
     ${charscript}: FORCE

The unrelated changes should have been committed in a separate patch
for easier bisection: a patch should contain a single logical change.

Please revert all of the unrelated makefile path handling changes so
master is buildable (the example above is one of many breakages).


reply via email to

[Prev in Thread] Current Thread [Next in Thread]