[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Fill column indicator functionality

From: Ergus
Subject: Re: Fill column indicator functionality
Date: Fri, 3 May 2019 19:49:35 +0200
User-agent: NeoMutt/20180716

Hi I think I fixed everything following your and Basil's suggestions.

spaces before the "*/" comment terminator.

+              if (EQ (Vdisplay_fill_column_indicator_column, Qt)
+                  && FIXNATP (BVAR (current_buffer, fill_column)))
+                fill_column_indicator_column =
+                  XFIXNAT (BVAR (current_buffer, fill_column));
+              else if (FIXNATP (Vdisplay_fill_column_indicator_column))
+                fill_column_indicator_column =
+                  XFIXNAT (Vdisplay_fill_column_indicator_column);

There's no 'else' clause here.  What will happen if neither of these
two conditions holds?  What do we want to happen then?

The variable is initialized to a right value that will no produce
indicator, so I don't actually need the else. But any way I made a small
change I like more.

Please quote fill-column-face `like this', so it will generate a link
in the *Help* buffer.

Finally, there are several places where you have left trailing
whitespace, please remove that.  Also, sometimes you left only 1 space
between sentences, whereas our convention is to leave 2.


Thanks to you!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]