[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Unit tests and lexical-binding for delim-col.el

From: Stefan Kangas
Subject: Re: [PATCH] Unit tests and lexical-binding for delim-col.el
Date: Wed, 8 May 2019 09:36:12 +0200

Basil L. Contovounesios <address@hidden> writes:
> Only a minor question from me, see below.
> [...]
> Why is buffer-string called twice in this and the following two tests?

Thank you for your input.  These calls were left there by mistake, fixed in the
attached patch.

> You said you were disinclined to adapt delim-col.el itself, but how
> about bundling the following minor cleanups as well?

Looks good to me.  I've included your cleanups in the attached patch.

Noam Postavsky <address@hidden> writes:
> I think you may as well go with defun here, delimit-columns-str isn't
> being used in some performance-critical spot, as far as I can tell.

You are probably correct.  However, I decided to leave Basil's changes as is,
since I don't know what would conventionally be considered cleaner/better in
this case.

Stefan Kangas

Attachment: 0001-lisp-delim-col.el-Use-lexical-binding.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]