[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Unit tests and lexical-binding for delim-col.el

From: Stefan Kangas
Subject: Re: [PATCH] Unit tests and lexical-binding for delim-col.el
Date: Thu, 30 May 2019 20:20:45 +0200

Basil L. Contovounesios <address@hidden> writes:
> > Stefan Monnier <address@hidden> writes:
> >> BTW, it would be nice to make it so that delimit-columns-region
> >> delegates to delimit-columns-rectangle when called with a rectangular
> >> region (i.e. using rectangle-mark-mode).
> >
> > Good idea.  How about the second patch attached here?

> I'm personally fine with this, but I think NEWS entries usually comprise
> a summary on the first line, followed by an elaboration in the body.
> I'm not very good at writing these, but here's one way to do that:
> Here's another possibility to reuse an existing NEWS entry under
> "Editing Changes":

Good thinking.  I think the version where we bundle this with other changes is
better.  But I would suggest to skip the implementation details.  See attached

Stefan Kangas

Attachment: 0001-Delegate-to-rectangle-version-in-delim-col-when-appr-2.patch
Description: Source code patch

reply via email to

[Prev in Thread] Current Thread [Next in Thread]