[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Unit tests and lexical-binding for delim-col.el

From: Basil L. Contovounesios
Subject: Re: [PATCH] Unit tests and lexical-binding for delim-col.el
Date: Wed, 08 May 2019 13:00:41 +0100
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux)

Stefan Kangas <address@hidden> writes:

> Noam Postavsky <address@hidden> writes:
>> I think you may as well go with defun here, delimit-columns-str isn't
>> being used in some performance-critical spot, as far as I can tell.
> You are probably correct.  However, I decided to leave Basil's changes as is,
> since I don't know what would conventionally be considered cleaner/better in
> this case.

It is always better to use defun until proven otherwise, see (info
"(elisp) Inline Functions").  The only reason I used defsubst was to be
more conservative, but if no-one minds then defun is indeed preferable.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]