[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Algorithm in electric-pair--unbalanced-strings-p unsuitable for CC M

From: João Távora
Subject: Re: Algorithm in electric-pair--unbalanced-strings-p unsuitable for CC Mode
Date: Wed, 3 Jul 2019 14:35:12 +0100

On Wed, Jul 3, 2019 at 2:08 PM Dmitry Gutov <address@hidden> wrote:
On 03.07.2019 13:58, Alan Mackenzie wrote:
>> But only in Emacs 27/cc-mode, probably starting from fe06f64b (that's
>> a git commit hash).
> I'm fully aware it's a git commit hash.  Funnily enough, I don't
> memorise such hashes, so if you wish to draw my attention to some
> commit, please have the decency to give me its date, and the summary
> line of its commit message, instead of expecting me to do your work to
> make your point.

The rest of the discussion aside, IMO it's a very strange reply. Though
I might be biased, given that a lot of my software-related discussions
are on platforms that linkify commit hashes.

Even so, is calling 'git show fe06f64b' too hard to do?

I would print its output on this occasion here, but in this case Git
says it's 'ambiguous'. So maybe Joao should elaborate.

I'm sorry it's fe06f643b2808b198bb58bda04a8c863e55a2a56, the
3 got lost in translation.

BTW I believe this is the commit that broke things, but it might have been
around this time.

commit fe06f643b2808b198bb58bda04a8c863e55a2a56
Author: Alan Mackenzie <address@hidden>
Date:   Fri Jun 8 16:42:18 2018 +0000

    CC Mode: Fontify unbalanced quotes in unconstrained multiline strings, etc.
    ("Unconstrained" meaning that every string is multiline, without needing such
    special marking as used by Pike Mode.)
    * lisp/progmodes/cc-mode.el (c-pps-to-string-delim): Don't process the char
    before BOB.
    (c-multiline-string-check-final-quote): New function.
    (c-bc-changed-stringiness): New variable.
    (c-before-change-check-unbalanced-strings): Add handling for unconstrained
    multiline strings.
    (c-after-change-re-mark-unbalanced-strings): Add handling for unconstrained
    multiline strings.  Handle escaped double quotes more accurately.

João Távora

reply via email to

[Prev in Thread] Current Thread [Next in Thread]