[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
bat-mode: Inconsistent fontification. Consider using font-lock-function-
bat-mode: Inconsistent fontification. Consider using font-lock-function-name-face
Mon, 9 Sep 2019 10:49:31 +0200
Mozilla/5.0 (Windows NT 10.0; WOW64; rv:68.0) Gecko/20100101 Thunderbird/68.0
Right now Emacs' bat-mode has an inconsistent use of faces, both
internally and w.r.t. to the rest of the Emacs universe.
In batch files you can create "labels". A label is a line whose
character is : followed by alpha-numerical characters.
These labels are often used via GOTO-statements for direct control flow,
but they can also be used via CALL-statements and then they work like
functions/subroutines and control is eventually returned to the caller.
CALL :subroutine param1 param2
Right now labels have one custom-face defined for bat-mode
(bat-label-face), and all -uses- of this label via GOTO or
CALL-statements has this label highlighted using font-lock-constant-face.
My proposal is that we change both these rules to instead be
font-lock-function-name-face. This solves both constency-problems:
- internal consistency of label/function fontification
- external consistency of function-name fontification.
Does anyone have an issue with such a change?
address@hidden 🍵 address@hidden
Re: bat-mode: Inconsistent fontification. Consider using font-lock-function-name-face, Stefan Monnier, 2019/09/09
- bat-mode: Inconsistent fontification. Consider using font-lock-function-name-face,
Jostein Kjønigsen <=