[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] `completing-read`: Add `group-function` support to completio

From: Daniel Mendler
Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 2)
Date: Sun, 2 May 2021 02:43:20 +0200

On 5/1/21 9:57 PM, Juri Linkov wrote:>> This seems to me like a mix of
vertical and horizontal layout.
> It's still the vertical layout but with grouping
> similar to how you sort candidates in every group,
> only here the per-group candidates are arranged vertically.
> Maybe this choice could be handled by an option?

Of course, we can add options to allow fine tuning of every behavior.
While I like the tuneability of Emacs I am not sure if it is advised to
make every tiny bit configurable. The way I wrote the current patch
allows the addition of custom `completions--insert-*` functions.
Furthermore there is always the advice mechanism, the possibility to
override functions etc, so I don't feel the need to add configurations
for every detail.

In my patch, I made this choice since it seemed more natural given the
distinction of horizontal and vertical insertion. By using a more
horizontal-like grouping, the distinction between the styles would be
less pronounced. However the arrangement you proposed is also
reasonable. I don't feel strongly about this and I am not against
offering this as configurable option or even as sole option.

In the patches are there more concrete issues which need to be addressed?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]