[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] `completing-read`: Add `group-function` support to completio

From: Juri Linkov
Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 7)
Date: Thu, 20 May 2021 20:53:51 +0300
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu)

>>>> I attached the updated patches, the variable `completions-group-sort`
>>>> allows the more user friendly values nil and 'alphabetical. I hope it is
>>>> more acceptable in this form.
>>> Thanks, this addresses my concerns.
>>> (Please proofread the comments, doc strings, and Texinfo changes in
>>> the patches to make sure you leave 2 spaces between sentences, per our
>>> conventions to use US English.)
>> Thank you, Eli. I went over the commit messages, comments, Texinfo and
>> doc strings and made a few corrections. The revised patches are attached.
> From my side the attached patches are ready. Is there anything else that
> should be addressed? Juri, does the `group-function` work as desired for
> `ucs-char-names` in the current form? See my last mail "REVISED PATCH

I tried out again, and everything works without problems.  Thank you!

Since there are no more objections, it seems the version 7 of your patch
is the final version, so I pushed it to master.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]