[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] `completing-read`: Add `group-function` support to completio

From: Daniel Mendler
Subject: Re: [PATCH] `completing-read`: Add `group-function` support to completion metadata (REVISED PATCH VERSION 6)
Date: Tue, 11 May 2021 22:30:44 +0200

On 5/11/21 9:59 PM, Eli Zaretskii wrote:
>> The snippet which I just sent is a proposal. Up to now there has been a
>> bit of back and forth of how the grouping feature is best implemented.
>> Under these circumstances it does not make sense to send a fully
>> polished patch each time. But by now the discussion seems to have
>> somehow concluded, or at least I interpret that there is some agreement
>> between the participants of the discussion which was mostly Juri,
>> Stefan, Dmitry and myself.
> Then please consider my humble request to make this user-friendlier by
> offering simple Lisp values, not just functions.  You and me can grasp
> 'identity or 'ignore with no trouble, but I'm not talking about you or
> me, or anyone else of the respected group mentioned above.  This
> feature is not just for us.

I attached the updated patches, the variable `completions-group-sort`
allows the more user friendly values nil and 'alphabetical. I hope it is
more acceptable in this form.


Attachment: 0001-completing-read-Add-group-function-to-completion-met.patch
Description: Text Data

Attachment: 0002-completion-insert-strings-Split-function-Full-group-.patch
Description: Text Data

Attachment: 0003-minibuffer-completion-help-Do-not-check-completions-.patch
Description: Text Data

Attachment: 0004-completion-insert-vertical-Separate-groups-completel.patch
Description: Text Data

Attachment: 0005-minibuffer-completion-help-Add-group-sorting.patch
Description: Text Data

reply via email to

[Prev in Thread] Current Thread [Next in Thread]