emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] Fix bookmark-bmenu-list sorting.


From: Eli Zaretskii
Subject: Re: [PATCH] Fix bookmark-bmenu-list sorting.
Date: Fri, 04 Mar 2022 13:46:36 +0200

> From: Karl Fogel <kfogel@red-bean.com>
> Cc: manuel@ledu-giraud.fr,  emacs-devel@gnu.org
> Date: Fri, 04 Mar 2022 02:18:44 -0600
> 
> On 04 Mar 2022, Eli Zaretskii wrote:
> >The original message didn't describe any bugs, so I concluded it 
> >was a
> >new feature.  Sorry about that.
> >
> >However, if this is a bug, please tell:
> >
> >  . what is the bug and how to reproduce it?
> >  . if this is a regression, what was the last Emacs version 
> >  where the
> >    reproduction recipe worked correctly?
> 
> The variable `bookmark-sort-flag' is not obeyed in 
> `bookmark-bmenu-mode' (that's the Dired-like mode entered 
> interactively via `edit-bookmarks').

But it _is_ obeyed in other places in bookmark.el, including in
bookmark-bmenu--revert (and thus in its callers).  So it isn't like
this variable is not obeyed at all, it's just that there seem to be
some specific situations where it isn't.

And you didn't answer my second question (and neither did Manuel).
Knowing whether this is a recent regression or not is important for
the decision whether to fix it now or later.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]