Re: [PATCH] Fix bookmark-bmenu-list sorting.

[Manuel Giraud]

Eli Zaretskii <eliz@gnu.org> writes:

[...]

> One more question: your patch included this part:
>
>> diff --git a/lisp/bookmark.el b/lisp/bookmark.el
>> index 2751731817..80fb1cdfc7 100644
>> --- a/lisp/bookmark.el
>> +++ b/lisp/bookmark.el
>> @@ -1819,7 +1819,7 @@ bookmark-bmenu--revert
>>                         (list location))])
>>                entries)))
>>      (tabulated-list-init-header)
>> -    (setq tabulated-list-entries entries))
>> +    (setq tabulated-list-entries (reverse entries)))
>>    (tabulated-list-print t))
>
> Why is that needed?

It is needed because the 'entries' list is constructed by iterating over
'bookmark-alist' and pushing new element to it. So in the end, 'entries'
is in the exact reverse order of 'bookmark-alist'.

As it seems intended that 'bookmark-alist' is ordered with most recent
bookmark at the beginning, I tried to keep this order in the "Bookmark
List" buffer.
-- 
Manuel Giraud