Re: master 6eeab90632: Don't accept whitespace or hex floats in rgbi: colour specs

[Po Lu]

Mattias Engdegård <mattiase@acm.org> writes:

> branch: master
> commit 6eeab90632506348a58d264eb3304625756c8659
> Author: Mattias Engdegård <mattiase@acm.org>
> Commit: Mattias Engdegård <mattiase@acm.org>
>
>     Don't accept whitespace or hex floats in rgbi: colour specs
>     
>     `color-values-from-color-spec` (new in Emacs 28) erroneously accepted
>     leading whitespace and hex floats in rgbi: components.
>     
>     Reported by Philip Kaludercic.
>     
>     * src/xfaces.c (parse_float_color_comp): Disallow leading whitespace
>     and hex floats.
>     * test/src/xfaces-tests.el
>     (xfaces-internal-color-values-from-color-spec): Add test cases.

I don't see a corresponding bug report, so please forgive me if I missed
something here.

If the leading whitespace and hex floats don't cause problems, why not
keep the ability to understand them?  It could come in handy.

Thanks.