Re: [PATCH] Fix bookmark-bmenu-list sorting.

[Karl Fogel]

On 21 Mar 2022, Manuel Giraud wrote:
> > In the tabulated-list header line at the top of the buffer, we 
> > have
> > the expected three columns: "Bookmark", "Type", and "File". The 
> > first
> > column, "Bookmark", has a down-triangle / up-triangle toggle 
> > for
> > switching between descending and ascending sort by bookmark 
> > name.  But
> > if `bookmark-sort-flag' is nil, then when the buffer is 
> > regenerated
> > the bookmarks will be listed in creation-date order -- and the
> > triangular toggle will just keep whichever value the triangle 
> > had
> > already.
>
> So yes that was what I was talking about (only better described 
> 😅).

Ah, got it, thanks!

> > Maybe the right fix for that is for the buffer to somehow 
> > indicate
> > *which* property the bookmarks are sorted by -- name or 
> > creation-date
> > -- and make sure that the triangle always reflects the sorting
> > direction of whichever thing is currently being sorted on. 
> > However,
> > before I go down that road, I'd like to fully understand your 
> > initial
> > "one minor thing" bug report above first.
>
> Or maybe you can «reset the state» of the tabulated-list (as it 
> is on
> first bookmark-bmenu-list call)? But I don't really know how
> tabulated-list works.

Okay -- I'll figure it out and Do The Right Thing.  Thank you, 
Manuel.

Best regards,
-Karl