[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: ELPA: New package: minibuffer-header

From: Stefan Monnier
Subject: Re: ELPA: New package: minibuffer-header
Date: Sat, 06 Aug 2022 18:03:21 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

Nicolas P. Rougier (inria) [2022-08-06 17:59:32] wrote:
> I would like to submit a new package to ELPA which is a minor-mode that
> display a header line in the minibuffer (and can optionally display messages
> as well).

I just added it to elpa.git, but it won't be released into GNU ELPA yet
because of the "Copyright" line in the file, which needs to be updated,
as in the patch below, which also tweaks the `.gitignore`.

After making those changes, you should be able to check the result at
Once you're satisfied, you'll need to additionally bump the `Version:`
in order to tell GNU ELPA to build a release tarball.

diff --git a/.gitignore b/.gitignore
new file mode 100644
index 0000000000..33b35ed269
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,3 @@
diff --git a/minibuffer-header.el b/minibuffer-header.el
index b511878710..bdba9b0303 100644
--- a/minibuffer-header.el
+++ b/minibuffer-header.el
@@ -1,6 +1,6 @@
 ;;; minibuffer-header.el --- Minibuffer header line -*- lexical-binding: t -*-
-;; Copyright (C) 2022 Nicolas P. Rougier
+;; Copyright (C) 2022  Free Software Foundation, Inc.
 ;; Maintainer: Nicolas P. Rougier <Nicolas.Rougier@inria.fr>
 ;; URL: https://github.com/rougier/minibuffer-header
@@ -173,7 +173,10 @@
                    'front-sticky t)))))))))
-(defun minibuffer-header--message-override (orig-fun &rest args)
+(defun minibuffer-header--message-override (_orig-fun &rest args)
+  ;; FIXME: Thje arglist looks wrong.  It's what I would expect for
+  ;; an `:around' advice, but not for an `:override' advice, which
+  ;; does not receive the `orig-fun'.
   "This advice is used to override the original message function"
   ;; Debug buffer (since we cannot use message for log)
@@ -182,7 +185,7 @@
   ;;  (insert (format "\n%s" args)))
   (let* ((msg (if (and (car args) (stringp (car ar

reply via email to

[Prev in Thread] Current Thread [Next in Thread]