Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349)

[Sean Whitton]

Hello,

On Tue 30 Aug 2022 at 02:54PM +03, Eli Zaretskii wrote:

>> From: Juri Linkov <juri@jurta.org>
>> Cc: Eli Zaretskii <eliz@gnu.org>,  Lars Ingebrigtsen <larsi@gnus.org>,
>>   emacs-devel@gnu.org
>> Date: Tue, 30 Aug 2022 10:20:10 +0300
>>
>> Anyway, the main point is that adepts of any existing VCS or any future
>> VCS can easily adapt their VCSes for this feature by just implementing
>> the backend call 'checkin-patch'.
>
> I very much hope this is not going to be the official policy of VC
> development in Emacs.  VC should IMO remain VCS-agnostic in its most
> important features, and "C-x v v" is definitely such a feature of VC.

Surely leaving room for things to be implemented for other VCs means
that it remains VC-agnostic.  With e.g. Magit there isn't even that room.

> That's basically the only real raison d'être of VC nowadays, because
> otherwise let's just obsolete VC and switch to Magit.

VC is far more flexible and Emacs-y than Magit in how it handles
buffers.  E.g. in Magit if you C-x x u a log buffer, because you want to
log something else at the same time, Magit will re-use the first log
buffer anyway.  So for those of us who like it when things are more
buffer-oriented, it remains a good alternative.

-- 
Sean Whitton