[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a pa
From: |
Juri Linkov |
Subject: |
Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349) |
Date: |
Tue, 30 Aug 2022 19:47:35 +0300 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (x86_64-pc-linux-gnu) |
>> But even if we initially only support this in otherwise clean trees,
>> it will be a huge advantage vs the current situation, where this
>> feature is simply not available.
>
> Will the advantage be significant? I really have to ask, because IME
> applying an external patch and them committing the files as a whole never
> felt particularly painful before (aside from resolving any conflicts or
> corrupted whitespace, which the new feature doesn't help with).
Indeed, just 'M-! git apply' before using 'vc-checkin-patch' will do the job
in case of an external patch.
> And 'diff-mode' has had the 'diff-apply-hunk' command for ages --
> I use it often.
>
> OTOH, the lack of support for workflow corresponding to 'git add -p' has
> been complained about frequently, it's one of the reasons people use Magit,
> and I felt it as well many times.
>
> To improve your workflow, though, might it help to add a new command
> 'diff-apply-buffer'?
There is 'ediff-patch-buffer' that does this interactively like 'git add -p'.
- Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349), (continued)
- Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349), Dmitry Gutov, 2022/08/29
- Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349), Eli Zaretskii, 2022/08/30
- Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349), Dmitry Gutov, 2022/08/30
- Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349), Eli Zaretskii, 2022/08/30
- Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349), Dmitry Gutov, 2022/08/30
- Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349), Eli Zaretskii, 2022/08/30
- Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349), Dmitry Gutov, 2022/08/30
- Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349),
Juri Linkov <=
- Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349), Eli Zaretskii, 2022/08/30
- Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349), Dmitry Gutov, 2022/08/30
- Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349), Eli Zaretskii, 2022/08/30
- Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349), Dmitry Gutov, 2022/08/30
- Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349), Juri Linkov, 2022/08/30
- Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349), Juri Linkov, 2022/08/30
- Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349), Eli Zaretskii, 2022/08/30
- Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349), Sean Whitton, 2022/08/30
- Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349), Eli Zaretskii, 2022/08/30
- Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349), Richard Stallman, 2022/08/30