[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a pa

From: Dmitry Gutov
Subject: Re: master 4803fba487 1/2: 'C-x v v' on a diff buffer commits it as a patch (bug#52349)
Date: Tue, 30 Aug 2022 20:39:24 +0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 30.08.2022 20:37, Eli Zaretskii wrote:
Date: Tue, 30 Aug 2022 20:11:52 +0300
From: Dmitry Gutov<dgutov@yandex.ru>

On 30.08.2022 20:05, Eli Zaretskii wrote:
Indeed, just 'M-! git apply' before using 'vc-checkin-patch' will do the job
in case of an external patch.
Unless some of the hunks are wrong or produce conflicts or are
rejected due to 1001 reasons.  Which is exactly the use case I thought
this enabled.  Sorry for misreading.
Not sure how we could possibly automate that problem away.
You don't need to.  Aborting a botched patch is easy; once the
problematic hunks are known (they are announced by Patch or by
"git apply"), you use this facility to filter them out, and
patch/commit again.

But filtering those out is not what one usually wants to do.

It's more common to want to install all the included changes, even if some might require fixing.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]