[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: CL packages landed

From: Gerd Möllmann
Subject: Re: CL packages landed
Date: Fri, 21 Oct 2022 08:48:13 +0200
User-agent: Gnus/5.13 (Gnus v5.13)

Stefan Kangas <stefankangas@gmail.com> writes:

> Gerd Möllmann <gerd.moellmann@gmail.com> writes:
>> I've pushed the branch "pkg" which implements CL packages for Emacs.
> I saw these GCC warnings while compiling:
> pkg.c:43:3: warning: function ‘pkg_error’ might be a candidate for
> ‘gnu_printf’ format attribute [-Wsuggest-attribute=format]
>    43 |   verror (fmt, ap);
>       |   ^~~~~~
> pkg.c:39:1: warning: function might be candidate for attribute
> ‘noreturn’ [-Wsuggest-attribute=noreturn]
>    39 | pkg_error (const char *fmt, ...)
>       | ^~~~~~~~~
> See the attached attempt to fix them.
> While playing around with this, I also came up with the attached small
> additions to the test suite (loosely based on the HyperSpec).

Thanks!  Please feel free to push on that branch.

> BTW, I think according to our branch naming conventions this should be
> named "feature/pkg"?

No idea, is that so?  Should I rename it? 

reply via email to

[Prev in Thread] Current Thread [Next in Thread]