Re: feature/package+vc 04c4c578c7 3/4: Allow for packages to be installed directly from VCS

[Philip Kaludercic]

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> That was my mistake, I misremembered that core packages aren't mirrored
>> in their own branches in elpa.git.  I've removed it here:
>
> LGTM, thanks!
> Feel free to push.
>
>> +         ((and (plist-member (cdr spec) :url)
>> +               (null (plist-get (cdr spec) :url)))
>> +          `((,(car spec)
>> +             :url ,(concat "https://git.sv.gnu.org/git/"; elpaa--gitrepo)
>> +             :branch ,(concat elpaa--branch-prefix (car spec))
>> +             ,@(cdddr spec))))
>
> The `cdddr` presumes the `:url nil` is at the very beginning (which is
> a valid assumption, indeed), whereas the `plist-member/get` dance tries
> to deal with the more general case.  I think you can simply that to
>
>     (pcase spec
>       (`(:url nil . ,props) ...)
>       ...)

Good point, I will apply this suggestion and then push the change.