emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: feature/package+vc 04c4c578c7 3/4: Allow for packages to be installe


From: Stefan Monnier
Subject: Re: feature/package+vc 04c4c578c7 3/4: Allow for packages to be installed directly from VCS
Date: Sat, 22 Oct 2022 10:53:53 -0400
User-agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux)

> That was my mistake, I misremembered that core packages aren't mirrored
> in their own branches in elpa.git.  I've removed it here:

LGTM, thanks!
Feel free to push.

> +         ((and (plist-member (cdr spec) :url)
> +               (null (plist-get (cdr spec) :url)))
> +          `((,(car spec)
> +             :url ,(concat "https://git.sv.gnu.org/git/"; elpaa--gitrepo)
> +             :branch ,(concat elpaa--branch-prefix (car spec))
> +             ,@(cdddr spec))))

The `cdddr` presumes the `:url nil` is at the very beginning (which is
a valid assumption, indeed), whereas the `plist-member/get` dance tries
to deal with the more general case.  I think you can simply that to

    (pcase spec
      (`(:url nil . ,props) ...)
      ...)


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]