[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: master 31945b6c3f: * lisp/progmodes/eglot.el (eglot): Ensure managed

From: Eli Zaretskii
Subject: Re: master 31945b6c3f: * lisp/progmodes/eglot.el (eglot): Ensure managed-major-mode is a list
Date: Sat, 29 Oct 2022 08:56:04 +0300

> From: Stefan Kangas <stefankangas@gmail.com>
> Date: Fri, 28 Oct 2022 12:45:58 -0700
> Cc: joaotavora@gmail.com, emacs-devel@gnu.org, stephen_leake@stephe-leake.org
> Eli Zaretskii <eliz@gnu.org> writes:
> > Our project-wide preference is the other way around: we ask
> > contributors not to make any whitespace changes except where they
> > actually change code, or nearby.
> AFAIK, the reasons not to do cosmetic whitespace changes is that they
> make history harder to read, and merging harder.

They also make patches harder to review, sometimes much harder.

> However, any reasonably modern VCS will have an option to ignore
> whitespace changes (Git does).  And a lot of code in Emacs change very
> infrequently.  At the same time, whitespace changes can in some cases
> make the structure of code clearer, and thereby easier to understand.
> I therefore think we could relax our project-wide policy along the lines
> of what Richard and João suggest.

Not as long as the "diff" operation of the VCS treats whitespace as
significant by default.  Presumably, they do this for a reason, and
therefore patches we get to review do not ignore whitespace.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]