emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: feature/package-vc has been merged


From: Philip Kaludercic
Subject: Re: feature/package-vc has been merged
Date: Wed, 09 Nov 2022 17:15:52 +0000

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Philip Kaludercic <philipk@posteo.net>
>> Cc: Eli Zaretskii <eliz@gnu.org>,  rms@gnu.org,  emacs-devel@gnu.org,  Lars
>>  Ingebrigtsen <larsi@gnus.org>
>> Date: Wed, 09 Nov 2022 08:15:52 +0000
>> 
>> +      `(add-to-list
>> +        'load-path
>> +        (file-name-concat
>
> Why file-name-concat and not expand-file-name?

Just because (file-name-concat foo nil) ≡ foo, but upon reflection I
think you are right in saying that `expand-file-name' would be cleaner.

>> +         ;; In case the package specification indicates that the lisp
>> +         ;; files are found in a subdirectory, append that path.
>                                                               ^^^^
> The entity you are talking about here is not a "path", AFAIU, it's a
> directory name.

Right, thanks for noticing.  Will fix both.

> Thanks.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]