Re: emacs-29 9b775ddc057 1/2: ; * etc/EGLOT-NEWS: Fix wording of last change.

[Philip Kaludercic]

Ruijie Yu <ruijie@netyu.xyz> writes:

> Philip Kaludercic <philipk@posteo.net> writes:
>
>> Philip Kaludercic <philipk@posteo.net> writes:
>>
>>> OK, then this is my proposal:
>>
>> I noticed a bug, here is a revised version:
>>
>> - (cond ((member status '("installed" "dependency" "unsigned"
>> "external"))
>> +        (cond ((member status (append
>> + '("installed" "dependency" "unsigned" "external" "built-in")
>> + (and package-install-upgrade-built-in '("built-in"))))
>
> I'm having a hard time understanding the significance of this portion.
> Why using (and ... '("built-in")) ?  AFACT, it adds matching status with
> "built-in", but unconditionally, because of the added element in the
> literal list?

You are right, the `and' was not necessary, I've removed it locally.
Will push the changes soon.

> And since the result of `member' is unused (except for checking its
> boolean value), whether it returns one or two copies of "built-in" would
> make no difference either.