emacs-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Adding refactoring capabilities to Emacs


From: Stefan Monnier
Subject: Re: Adding refactoring capabilities to Emacs
Date: Thu, 07 Sep 2023 18:03:31 -0400
User-agent: Gnus/5.13 (Gnus v5.13)

>>>> but that's already taken in diff-mode.
>> I don't think the current `C-c C-c` binding in `diff-mode` should get in
>> the way.  That command is available via different bindings already, and
> diff-apply-everything is a little destructive, though (there is no 'undo'
> across multiple files), so maybe a warning could help. Or make it an
> initially-disabled command, for example.

But in the context of a refactoring operation, it wouldn't make sense to
disable it.

>> this is a specific use of diff-mode where `diff-apply-everything` makes
>> a lot of sense (as opposed to `C-x v =` where the changes are usually
>> already applied anyway so `diff-apply-everything` is rarely what we want).
> So... the binding wouldn't be used in "regular" Diff buffers,

That's indeed a possible option (e.g. use a mode that's derived from
`diff-mode` but with a different `C-c C-c` binding, or activate
a special "refactoring minor mode" to provide that binding).


        Stefan




reply via email to

[Prev in Thread] Current Thread [Next in Thread]