Re: master 78fc49407b8 1/3: Improve filling of ChangeLog entries

[Po Lu]

Stefan Kangas <stefankangas@gmail.com> writes:

> Po Lu via Mailing list for Emacs changes <emacs-diffs@gnu.org> writes:
>
>> branch: master
>> commit 78fc49407b8ef8ec649fe70fcce09101801dbc05
>> Author: Po Lu <luangruo@yahoo.com>
>> Commit: Po Lu <luangruo@yahoo.com>
>>
>>     Improve filling of ChangeLog entries
>>
>>     * lisp/vc/log-edit.el (log-edit--insert-filled-defuns): Rewrite
>>     completely.
>>     (log-edit-fill-entry): Abandon pcase and cl-lib.
>
> Speaking of commit messages, the above is not at all clear to me.
> More specifically, the word "improve" seems open to interpretation.
>
> Is it just a rewrite to "abandon pcase and cl-lib"?  If yes, I think
> that is what should have gone on the first line summary.
>
> If that's not it, what is it that has been improved?

Several bugs causing entries to be improperly filled have been fixed,
and probably countless more I was unaware of; with fill-column set to
44, for example,

* lisp/progmodes/cmake-ts-mode.el 
(treesit-induce-sparse-tree)
(treesit-node-child, treesit-node-start)
(cmake-ts-mode--imenu)
(cmake-ts-mode--imenu-1): Remove.
(treesit-search-subtree): Declare.
(cmake-ts-mode--function-name): New
function.
(cmake-ts-mode): Use it.

would have been filled to:

* lisp/progmodes/cmake-ts-mode.el 
(treesit-induce-sparse-tree)
(treesit-node-child, treesit-node-start)
(cmake-ts-mode--imenu,
cmake-ts-mode--imenu-1): Remove.
(treesit-search-subtree): Declare.
(cmake-ts-mode--function-name): New
function.
(cmake-ts-mode): Use it.

Not understanding the original code, it was not possible for me to
describe the change in greater detail.