Re: master a739cab6637 2/2: ; * doc/lispref/display.texi (Image Descriptors): Insert missing text.

[Po Lu]

Eli Zaretskii <eliz@gnu.org> writes:

>> From: Robert Pluim <rpluim@gmail.com>
>> Cc: Po Lu <luangruo@yahoo.com>
>> Date: Mon, 03 Jun 2024 13:27:22 +0200
>> 
>> >>>>> On Mon, 3 Jun 2024 04:36:43 -0400 (EDT), Po Lu via Mailing
>> list for Emacs changes <emacs-diffs@gnu.org> said:
>> 
>>     Po Lu> branch: master
>>     Po Lu> commit a739cab66378a367cef8fa3a59f7ccb70a56bbb4
>>     Po Lu> Author: Po Lu <luangruo@yahoo.com>
>>     Po Lu> Commit: Po Lu <luangruo@yahoo.com>
>> 
>> 
>> The text now reads
>> 
>>     @vindex image-scaling-factor
>>     Alternatively, the symbol @code{default} may be specified, indicating
>>     that the image should be scaled according as the value of the
>>     @code{image-scaling-factor} variable is the default @code{auto} or a
>>     number, which by default scales the image in proportion to the average
>>     widths (@pxref{Low-Level Font}) of the default faces of frames on which
>>     it happens to be displayed, if such widths should exceed @code{10}
>>     pixels.  If no other value is provided, @code{create-image} will specify
>>     this value in image specifications it creates.
>> 
>> which apart from saying 'according as' rather than 'according to' is
>> completely incomprehensible to me.
>
> Agreed.  Po Lu, can you please fix that text?

Is it "according as XXX or YYY" that is incomprehensible to both of you,
or just the punctuation?  "According to whether XXX or YYY" is not
appropriate in this context, I think, as it implies that the choice
between the two options is the only factor that affects the image's
scaling, while there is really also the value of the variable that the
latter option refers to, whose values and their effects are elaborated
immediately afterwards.