[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [ft-devel] otvalid modules

From: Werner LEMBERG
Subject: Re: [ft-devel] otvalid modules
Date: Sat, 11 Aug 2007 10:22:26 +0200 (CEST)

> Please apply the otvmathconstant patch


> The patch coverageCount passes an extra argument to
> otv_Coverage_validate (the expected number of glyphs, or -1 if this
> is not known -- it isn't always) and then checks that these counts
> match.


> I may be wrong, and perhaps the authors had something else in mind
> and my patch may be inappropriate. So please examine the invalidGID
> patch and only apply it if appropriate.

Applied.  However, I think there is a mistake for the
SingleSubstFormat1 case:

        idx = otv_Coverage_get_first( Coverage ) + DeltaGlyphID;
        if ( idx < 0                                           ||
             idx + DeltaGlyphID < 0                            ||
             (FT_UInt)idx + DeltaGlyphID >= valid->glyph_count )

The code adds DeltaGlyphID to idx, and then you are checking whether
`idx + DeltaGlyphID < 0'...  This looks wrong to me.  I don't have
time currently to verify this.  Please post a patch if necessary.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]