Re: [Gnash] Patch to (partially) implement Actionscript Arrays

[Michael Carlson]

On 1/21/06, strk <address@hidden> wrote:
> Michael, I'm adding your test cases to gnash.
> Can the test be simplified to version 6 ?
> I'd like tests to be buildable with Ming and I think
> we should test version 6 things first.
>
> --strk;

I can compile it as version 6 with mtasc, if that's what you mean.
Just add a "-version 6" switch when compiling. Curiously, using the
same actionscript file but in a version 6 flash file, not everything
works under my array code in gnash. Specifically, several things that
in the test "should" come out as "undefined", come out as a blank
string, or sometimes "null". I think all of the other things work ok.

Before I start digging into this problem, is there anything obvious
you know of that might be the cause of this? Do we actually check in
gnash the version number of the flash file and behave differently
regarding actionscript? What is the big difference between flash 6 and
7? I never knew much about flash and was never a flash author before,
so I'm still learning about all of this.

- Mike

>
> On Tue, Jan 17, 2006 at 07:17:18PM +0800, Michael Carlson wrote:
> > In the past couple of days, I've been working on getting actionscript arrays
> > working in gnash as hopefully the first of many significant contributions to
> > the project. Attached is my initial patch "arraypatch1", an actionscript
> > file "test.as" to test with (which can be compiled through MTASC - see
> > www.mtasc.org), and a flash file "array.swf" (which is simply
> > test.ascompiled into swf form through MTASC, for convenience) which
> > tests the
> > implemented functions.
> >
> > Only the following actions are supported at this time: initialization
> > through constructors, initialization the "normal" way (var a = [4,1,2];),
> > accessing / setting array members, length(), push(), and pop().
> >
> > I've found the best way to test this is to run "gnash -va array.swf | grep
> > TRACE | grep -v \" | grep -v -- ---". This will extract and display all of
> > the relevant trace messages out of the output of gnash, excluding most of
> > the extraneous output. This can then be compared with the actionscript
> > source file, test.as.
> >
> > My last patch (very small) hasn't been replied to yet - I hope I'm sending
> > this to the right place. Looking forward to any comments people have about
> > it.
> >
> > I'd like to add, all of this was done without looking at any documents that
> > require a restrictive agreement (I didn't look at Macromedia's official
> > documents); I used an unofficial actionscript reference at
> > sephiroth.it/reference.php. All of my patches will be done in this way.
>
>
>
>
> > _______________________________________________
> > Gnash mailing list
> > address@hidden
> > http://lists.gnu.org/mailman/listinfo/gnash
>
>
> --
>
>  /"\    ASCII Ribbon Campaign
>  \ /    Respect for low technology.
>   X     Keep e-mail messages readable by any computer system.
>  / \    Keep it ASCII.
>
>