[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [patch] assume working unix98 PTYs

From: David Vrabel
Subject: Re: [patch] assume working unix98 PTYs
Date: Mon, 24 Jan 2005 14:39:00 +0000
User-agent: Debian Thunderbird 1.0 (X11/20050116)

Paweł Kot wrote:
Dnia wto 11. stycznia 2005 13:14, David Vrabel napisał:

It doesn't seem necessary to do configure time check for working UNIX98
PTYs.  I would consider it sufficient to check for grantpt().

Are you sure? I belive it was not enough at the time it was written.

The current configure time check is broken when cross-compiling.

It doesn't make sense to me to check for run-time features at build time. It's rather common for packages to run on different system than the one it was built on.

I considered making it a run time test but decided not to -- any
reasonably recent system will have support for UNIX98 PTYs.

And probably we can't assume that. Slackware 4.0 did not have and it was the OS where I wrote that ;-)

I don't think Slackware 4.0 counts as reasonably recent anymore ;)

That said, here's a far simpler patch that fixes up the cross-compile case only.

David Vrabel
David Vrabel, Design Engineer

Arcom, Clifton Road           Tel: +44 (0)1223 411200 ext. 3233
Cambridge CB1 7EA, UK         Web:
diff -ur gnokii-0.6.4.orig/ gnokii-0.6.4/
--- gnokii-0.6.4.orig/      Sun Oct 17 20:44:20 2004
+++ gnokii-0.6.4/   Tue Jan 11 11:48:39 2005
@@ -489,7 +489,7 @@
                 AC_MSG_WARN("No unix98ptys"),
-               AC_MSG_WARN("Ensure to disable unix98ptys when crosscompiling"))
+               AC_DEFINE(USE_UNIX98PTYS))

reply via email to

[Prev in Thread] Current Thread [Next in Thread]