[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Gnu-arch-users] [REJECT: address@hidden (default naming convention chan

From: Tom Lord
Subject: [Gnu-arch-users] [REJECT: address@hidden (default naming convention changes)
Date: Wed, 5 May 2004 12:27:44 -0700 (PDT)

The gist of the proposed changes to the default naming conventions

      case arch_inventory_backup:
 -        return str_save (0, 
 +        return str_save (0, 
      case arch_inventory_junk:
 -        return str_save (0, "^(,.*)$");
 +        return str_save (0, 
      case arch_inventory_unrecognized:
 -        return str_save (0, 
 +        return str_save (0, "^.*(\\.rej)$");

The problems include:

1) .rej is in the same conceptual class as .orig, .original,
   .modified, and .reject --- they should all be handled the same way.

2) .o, .a, .so, .core, and .so* do not belong in junk.
   Those files can be very, very valuable _and_ difficult or
   impossible to reproduce.   "junk", meanwhile, is comprised of files
   that may be casually deleted.

3) .rej does not belong in unrecognized.   For example, suppose I am
   going to replay a few different patches (as I did when
   cherry-picking for this merge before deciding not to commit it).
   I may get conflicts in an early one but keep going anyway.
   Putting .rej in unrecognized would cause problems.

The rationale for these changes was:

    This way someone can use tla out of the box exactly like how
    cvs/svn/whatever are used for typical projects.

which is not enough justification to overcome the problems mentioned


reply via email to

[Prev in Thread] Current Thread [Next in Thread]