grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: Partition modules


From: Yoshinori K. Okuji
Subject: Re: Partition modules
Date: Thu, 18 Nov 2004 10:28:49 +0100
User-agent: KMail/1.6.1

On Wednesday 17 November 2004 20:25, Marco Gerards wrote:
> Can someone please this patch on the PC for me to see if it works?  I
> don't know when I can do that, I just tried if it compiles correctly
> on the PC.

Don't expect me to test it... I might be able to have time in this 
weekend, but no guarantee.

> Index: include/grub/pc_partition.h
> ===================================================================
> RCS file: include/grub/pc_partition.h
> diff -N include/grub/pc_partition.h
> --- /dev/null 1 Jan 1970 00:00:00 -0000
> +++ include/grub/pc_partition.h       17 Nov 2004 19:12:22 -0000
> @@ -0,0 +1,190 @@
[snip]

The macros defined in this header should use different names, because 
GRUB_PARTITION_FOO is too generic. Maybe GRUB_PC_PARTITION_FOO?

The other parts look good for me.

Thanks,
Okuji




reply via email to

[Prev in Thread] Current Thread [Next in Thread]