[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: sparc64 port : diffs to powerpc branches

From: Hollis Blanchard
Subject: Re: sparc64 port : diffs to powerpc branches
Date: Tue, 12 Jul 2005 17:17:50 -0500

On Jul 12, 2005, at 1:46 PM, Vincent Pelletier wrote:
Here are the diffs powerpc -> usparc, with some comments below.
To be used to know which files can be made common.

I will see about moving the easily shared files.

cmain renamed in _start (no asm).

Sparc will need to provide its own cmain.c and init.c; these files cannot be shared.

Special ppc options removed.
All the ieee1275 functions use the grub_intn_t type (see includes).
Add explicit casts where needed.

--- powerpc/ieee1275/ieee1275.c 2005-06-21 04:33:51.000000000 +0200
+++ sparc64/ieee1275/ieee1275.c 2005-07-12 20:05:49.000000000 +0200
@@ -42,43 +41,43 @@ grub_ieee1275_finddevice (char *name, gr
    struct find_device_args {
      struct grub_ieee1275_common_hdr common;
-    char *device;
-    grub_ieee1275_phandle_t phandle;
+    grub_intn_t device;
+    grub_intn_t phandle;
    } args;

As we discussed on IRC, "grub_intn_t" should instead be called "grub_ieee1275_cell_t", defined as 32 bits on PPC and 64 bits on Sparc.

Make "exit" call a "no return".

Special ppc test removed.
Types changed.

Sparc should provide its own grub_ieee1275_test_flag(), as this is a good and trivially portable abstraction. We will then need a consolidated list of flags (common to all IEEE1275 architectures).

Type changes.
Added an environment variable to disable cls (useful to see early messages).

This is useful, but I believe we should use the already-defined "debug" environment variable for this. After all, if we have set "debug," we probably would like to see the output without the screen being cleared.

Brute changes... Like dl, I don't know when it is used, so...

You may very well need a grub-mkimage.c, but you do not need to hack up PowerPC's. :)

I will look into these applying some of these changes now...


reply via email to

[Prev in Thread] Current Thread [Next in Thread]