[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: GPT on PC/BIOS computers
From: |
Marco Gerards |
Subject: |
Re: GPT on PC/BIOS computers |
Date: |
Fri, 04 May 2007 10:40:17 +0200 |
User-agent: |
Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) |
Robert Millan <address@hidden> writes:
> Here's a patch to enable GPT support for PC/BIOS systems. Need for GPT is
> increasingly common due availability of > 2 TiB hard drives.
>
> Please let me know if everything is correct.
>
> Some testing would be welcome, too (but be careful, earlier versions of my
> patch had a "feature" that fucked up your partition table - hopefuly fixed
> now, at least Works For Me [tm]).
Have you tested it on MBR?
> --
> Robert Millan
>
> My spam trap is address@hidden Note: this address is only intended
> for spam harvesters. Writing to it will get you added to my black list.
>
> 2007-05-01 Robert Millan <address@hidden>
>
> * conf/i386-pc.rmk (grub_setup_SOURCES): Add partmap/gpt.c.
> (grub_probe_SOURCES): Likewise.
> * conf/i386-pc.mk: Regenerate.
No need to mention this.
> * util/i386/pc/biosdisk.c (grub_util_biosdisk_get_grub_dev): Detect
> GPT and initialize dos_part and bsd_part accordingly.
> * util/i386/pc/grub-setup.c: Ditto for install_dos_part and
> install_bsd_part.
> * util/i386/pc/grub-install.in: Add gpt module to core.img.
> * util/i386/pc/grub-probe.c: Activate gpt module for use during
> partition identification, and deactivate it afterwards.
> * util/i386/pc/grub-setup.c: Ditto.
You don't mention in which function you do these things, just the
files. Can you correct this? I personally would prefer if you do not
split up the changelog entries for one file, perhaps it is not even
allowed by the GCS.
> Index: util/i386/pc/grub-install.in
> ===================================================================
> RCS file: /sources/grub/grub2/util/i386/pc/grub-install.in,v
> retrieving revision 1.11
> diff -u -r1.11 grub-install.in
> --- util/i386/pc/grub-install.in 10 Apr 2007 21:38:26 -0000 1.11
> +++ util/i386/pc/grub-install.in 1 May 2007 18:56:07 -0000
> @@ -216,8 +216,8 @@
> exit 1
> fi
>
> -# Typically, _chain and pc are required.
> -modules="$modules $fs_module _chain pc"
> +# Typically, _chain, pc and gpt are required.
> +modules="$modules $fs_module _chain pc gpt"
It would be nice if we were able to use grub-probe to determine
this... But for now this is fine, I think.
--
Marco
- GPT on PC/BIOS computers, Robert Millan, 2007/05/01
- Re: GPT on PC/BIOS computers, Javier Rodríguez Sánchez, 2007/05/03
- Re: GPT on PC/BIOS computers, Robert Millan, 2007/05/03
- Re: GPT on PC/BIOS computers, Javier Rodríguez Sánchez, 2007/05/03
- Re: GPT on PC/BIOS computers, Javier Rodríguez Sánchez, 2007/05/04
- Re: GPT on PC/BIOS computers, Robert Millan, 2007/05/04
- Re: GPT on PC/BIOS computers, Marco Gerards, 2007/05/05
- Re: GPT on PC/BIOS computers, Javier Rodríguez Sánchez, 2007/05/06
Re: GPT on PC/BIOS computers,
Marco Gerards <=