[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] biosdisk / open_device() messing up offsets

From: Pavel Roskin
Subject: Re: [PATCH] biosdisk / open_device() messing up offsets
Date: Thu, 12 Jun 2008 00:01:14 -0400
User-agent: Internet Messaging Program (IMP) H3 (4.1.4)

Quoting Bean <address@hidden>:

I think we should consider having a journaling layer above
grub_disk_read() that would do the substitution and avoid such bugs in
the future.

This should be all right, but we need to move the journal support from
fshelp.c to disk.c, anyone objects ?

No objection from me. But if it's complicated, we can start with an ext2 specific function that would translate offset and size to block numbers, apply journal mappings and read the data.

Pavel Roskin

reply via email to

[Prev in Thread] Current Thread [Next in Thread]