Re: [PATCH] kern/err.c + disk/raid.c error handling fixes

[Felix Zielcke]

On Tue, Aug 12, 2008 at 11:42:58PM +0200, Marco Gerards wrote:
> >         * kern/err.c [GRUB_UTIL]: Include <stdio.h>.

> Please don't do this.  Why do you want this?

It's needed for fprintf, and fprintf is only useful for GRUB_UTIL.

> >"...reset grub_errno.  Do not..."
> (double space)

Right, I should really pay more attention to these small little details.

Am Mittwoch, den 13.08.2008, 00:40 +0200 schrieb Robert Millan:
> > 
> > It would be better to make a util/misc.c:grub_print_error instead of this
> 
> Problem is that kern/err.c is already included in grub-probe.  So then we 
> would
> have to add util/misc.c:grub_print_error _and_ disable grub_print_error.

Thanks for your hint.

> > Please use -up for diff, you can use:
> > $ svn diff --diff-cmd diff -x -up
> 
> Thanks for the tip, I've been looking for this ;-)
> 
I made now a svn-diff alias for this :)

I hope it's now better, but I was unsure about the `new function' in
changelog it isn't really a new one more a modified one.

2008-08-13  Felix Zielcke  <address@hidden>

        * include/kern/err.h [! GRUB_UTIL]: Disable.
        * kern/err.c [! GRUB_UTIL] (grub_print_error): Likewise.

        * include/util/misc.h (grub_print_error): New function prototype.
        * util/misc.c (grub_print_error): New function.

        * disk/raid.c (GRUB_MOD_INIT): Use grub_print_error() to show RAID
        errors and reset grub_errno.  Do not give errors to the upper layer.

error.diff
Description: Text Data