[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] kern/err.c + disk/raid.c error handling fixes
From: |
Vesa Jääskeläinen |
Subject: |
Re: [PATCH] kern/err.c + disk/raid.c error handling fixes |
Date: |
Thu, 14 Aug 2008 21:16:35 +0300 |
User-agent: |
Thunderbird 2.0.0.16 (Windows/20080708) |
Robert Millan wrote:
> On Thu, Aug 14, 2008 at 01:02:30PM +0200, Felix Zielcke wrote:
>> +int
>> +grub_err_printf (const char *fmt, ...)
>> +{
>> + va_list ap;
>> + int ret;
>> +
>> + va_start (ap, fmt);
>> + ret = vfprintf (stderr, fmt, ap);
>> + va_end (ap);
>> +
>> + return ret;
>> +}
>> void *
>> xmalloc (size_t size)
>
> Please separate functions with an empty line. Anyway, no need to send a new
> patch just for this.
>
> Marco, is it fine to you now?
>
Please use grub's own string formatter.
- Re: [PATCH] kern/err.c + disk/raid.c error handling fixes, (continued)
- Re: [PATCH] kern/err.c + disk/raid.c error handling fixes, Felix Zielcke, 2008/08/13
- Re: [PATCH] kern/err.c + disk/raid.c error handling fixes, Marco Gerards, 2008/08/13
- Re: [PATCH] kern/err.c + disk/raid.c error handling fixes, Felix Zielcke, 2008/08/13
- Re: [PATCH] kern/err.c + disk/raid.c error handling fixes, Felix Zielcke, 2008/08/13
- Re: [PATCH] kern/err.c + disk/raid.c error handling fixes, Robert Millan, 2008/08/13
- Re: [PATCH] kern/err.c + disk/raid.c error handling fixes, Felix Zielcke, 2008/08/13
- Re: [PATCH] kern/err.c + disk/raid.c error handling fixes, Felix Zielcke, 2008/08/13
- Re: [PATCH] kern/err.c + disk/raid.c error handling fixes, Marco Gerards, 2008/08/14
- Re: [PATCH] kern/err.c + disk/raid.c error handling fixes, Felix Zielcke, 2008/08/14
- Re: [PATCH] kern/err.c + disk/raid.c error handling fixes, Robert Millan, 2008/08/14
- Re: [PATCH] kern/err.c + disk/raid.c error handling fixes,
Vesa Jääskeläinen <=
- Re: [PATCH] kern/err.c + disk/raid.c error handling fixes, Marco Gerards, 2008/08/14
- Re: [PATCH] kern/err.c + disk/raid.c error handling fixes, Felix Zielcke, 2008/08/14
- Re: [PATCH] kern/err.c + disk/raid.c error handling fixes, Robert Millan, 2008/08/13
- Re: [PATCH] kern/err.c + disk/raid.c error handling fixes, Marco Gerards, 2008/08/13